Skip to content

[feat] Add possibility to inherit the prefix from the parent class #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 17, 2020
Merged

[feat] Add possibility to inherit the prefix from the parent class #1570

merged 8 commits into from
Nov 17, 2020

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Nov 3, 2020

Closes #1569

@codecov-io
Copy link

codecov-io commented Nov 3, 2020 •
edited
Loading

Codecov Report

Merging #1570 (6f67a6c) into master (3ad9e85) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
+ Coverage   87.57%   87.61%   +0.03%     
==========================================
  Files          45       45              
  Lines        7244     7249       +5     
==========================================
+ Hits         6344     6351       +7     
+ Misses        900      898       -2
Impacted Files Coverage Δ
reframe/core/pipeline.py 92.13% <100.00%> (+0.06%) ⬆️
reframe/frontend/loader.py 92.56% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad9e85...6f67a6c. Read the comment docs.

@vkarak vkarak requested review from victorusu and vkarak November 3, 2020 09:53
@vkarak vkarak assigned vkarak and jjotero and unassigned vkarak Nov 3, 2020
vkarak
vkarak requested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a unit test for this functionality.

@pep8speaks
Copy link

pep8speaks commented Nov 3, 2020 •
edited
Loading

Hello @jjotero, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-11-17 15:45:52 UTC

@jjotero
Copy link
Contributor Author

jjotero commented Nov 3, 2020

We will need a unit test for this functionality.

Done.

@vkarak vkarak added this to the ReFrame sprint 20.17 milestone Nov 6, 2020
@victorusu victorusu changed the title [feat] ReFrame base tests [feat] Add possibility to refer to other test's sources Nov 6, 2020
victorusu
victorusu approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjotero jjotero changed the title [feat] Add possibility to refer to other test's sources [feat] Add possibility to inherit the prefix from the parent class Nov 6, 2020
vkarak
vkarak requested changes Nov 12, 2020
View reviewed changes
vkarak
vkarak approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'm going to push a couple of minor changes.

@vkarak vkarak merged commit 67e66aa into reframe-hpc:master Nov 17, 2020
@jjotero jjotero deleted the feature/base-tests branch December 9, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@jjotero jjotero

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.17

Development

Successfully merging this pull request may close these issues.

Allow derived tests to inherit the prefix of their parent tests

5 participants

@jjotero @codecov-io @pep8speaks @vkarak @victorusu